Skip to content

Add support for query tokenization parameters#435

Draft
matt-bernhardt wants to merge 3 commits into
mainfrom
use-636
Draft

Add support for query tokenization parameters#435
matt-bernhardt wants to merge 3 commits into
mainfrom
use-636

Conversation

@matt-bernhardt

Copy link
Copy Markdown
Member

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@qltysh

qltysh Bot commented Jul 22, 2026

Copy link
Copy Markdown

❌ 3 blocking issues (3 total)

Tool Category Rule Count
rubocop Lint Method has too many lines. [11/10] 2
rubocop Lint Assignment Branch Condition size for initialize is too high. [<7, 20, 5> 21.77/17] 1

@mitlib
mitlib temporarily deployed to timdex-ui-pi-use-636-1nr9riqsh July 22, 2026 16:48 Inactive
@mitlib
mitlib temporarily deployed to timdex-ui-pi-use-636-1nr9riqsh July 22, 2026 18:53 Inactive
@coveralls

coveralls commented Jul 22, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29954427312

Coverage increased (+0.005%) to 98.389%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 8 of 8 lines across 4 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1552
Covered Lines: 1527
Line Coverage: 98.39%
Coverage Strength: 85.86 hits per line

💛 - Coveralls

extract_tokenization_params(enhanced_query)
@query['index'] = ENV.fetch('TIMDEX_INDEX', nil)
@query['booleanType'] = enhanced_query[:booleanType]
@query.compact!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Assignment Branch Condition size for initialize is too high. [<7, 20, 5> 21.77/17] [rubocop:Metrics/AbcSize]


2. Method has too many lines. [15/10] [rubocop:Metrics/MethodLength]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants