Skip to content

Remove underscore from method name#15

Merged
ehanson8 merged 1 commit into
mainfrom
IN-1787-bug-fix
Jul 9, 2026
Merged

Remove underscore from method name#15
ehanson8 merged 1 commit into
mainfrom
IN-1787-bug-fix

Conversation

@ehanson8

@ehanson8 ehanson8 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Purpose and background context

The underscore in _calculate_growth_by_field triggered a marimo behavior to rename private methods at runtime so they can't be used by other cells.

How can a reviewer manually see the effects of these changes?

These changes were verified locally by myself and Charlie

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

What are the relevant tickets?

Why these changes are being introduced:
* The underscore in _calculate_growth_by_field triggered a marimo behavior to rename private methods so they can't be used by other cells

How this addresses that need:
* Rename _calculate_growth_by_field > calculate_growth_by_field
* Update dependencies and remove outdated pip-audit ignore

Side effects of this change:
* NA

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1787
@ehanson8
ehanson8 requested a review from a team as a code owner July 9, 2026 19:17
@ehanson8
ehanson8 requested a review from jonavellecuerdo July 9, 2026 19:17
@ehanson8
ehanson8 merged commit ae7db7e into main Jul 9, 2026
2 checks passed
@ehanson8
ehanson8 deleted the IN-1787-bug-fix branch July 9, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants