[WIP] Drop the BUNDLED WITH pin from the jack-core generator lock#291
Draft
Tynan Burke (thearchduke) wants to merge 1 commit into
Draft
[WIP] Drop the BUNDLED WITH pin from the jack-core generator lock#291Tynan Burke (thearchduke) wants to merge 1 commit into
Tynan Burke (thearchduke) wants to merge 1 commit into
Conversation
The lock pins bundler 1.17.3, which the jar's consumers don't have installed -- db_schemas' Maven build runs Ruby 2.7 with bundler 2.1.4, and rubygems hard-errors "Could not find 'bundler' (1.17.3)" before the generator runs. Without the stanza bundler uses whatever version is installed. The bigdecimal 1.3.5 pin stays; it's the Ruby 2.7 build fix from #280. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having trouble with the db_schemas build due to bundler versions.
The lock file currently pins bundler 1.17.3, which the jar's consumers don't have installed--db_schemas' Maven build runs Ruby 2.7 with bundler 2.1.4, and rubygems hard-errors "Could not find 'bundler' (1.17.3)" before the generator runs. If we remove these lines, bundler will use whatever version is installed.
Waiting to confirm that this is the issue and we do not need further edits to this library, via a shim in the db_schemas build.