Skip to content

fix(metadata): treat Audible's empty product stub as no answer so the provider chain can continue #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kevinheneveld wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

fix(metadata): treat Audible's empty product stub as no answer so the provider chain can continue #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions listenarr.application/Metadata/Core/AudiobookMetadataService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,18 @@ public AudiobookMetadataService(
continue;
}

// An ASIN missing from Audible's catalog comes back as a
// non-null but EMPTY product stub (no title, no fields).
// Treating that as an answer both returns junk to the
// caller and blocks every later source in the chain.
if (result is AudibleBookResponse shell && string.IsNullOrWhiteSpace(shell.Title))
{
_logger.LogInformation(
"{SourceName} returned an empty product stub for ASIN {Asin}; treating as no answer",
source.Name, asin);
result = null;
}

if (result != null)
{
_logger.LogInformation("Successfully fetched metadata from {SourceName} for ASIN: {Asin}", source.Name, asin);
Expand Down