chore: validate PR 717 review-fix application

.github/workflows/temporary-test-diagnostics.yml

@@ -0,0 +1,102 @@
+name: Temporary Windows Test Diagnostics
+
+on:
+  pull_request:
+
+permissions:
+  contents: write
+  pull-requests: write
+  issues: write
+
+jobs:
+  diagnose-windows:
+    if: github.event.pull_request.head.repo.full_name == github.repository
+    runs-on: windows-2025
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.head_ref }}
+      - uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 10.0.x
+      - name: Restore
+        run: dotnet restore
+      - name: Apply recovery marker invariant and format
+        shell: pwsh
+        run: |
+          $path = 'listenarr.infrastructure/Library/Moving/AudiobookContentMoveService.cs'
+          $content = Get-Content $path -Raw
+          $old = @'
+          if (string.Equals(recoveryStage, CopyCompletedStage, StringComparison.Ordinal)
+              && LoadManifest(request.JobId).Count == 0)
+          {
+              throw new MoveNeedsAttentionException(
+                  "A legacy copy-complete marker has no byte-verified manifest; source cleanup is blocked.");
+          }
+          '@
+          $new = @'
+          if (recoveryStage is CopyStartedStage or CopyCompletedStage
+              && LoadManifest(request.JobId).Count == 0)
+          {
+              throw new MoveNeedsAttentionException(
+                  "A move recovery marker exists without a persisted manifest; destination ownership cannot be proven.");
+          }
+          '@
+          if ($content.Contains($old)) {
+            $content = $content.Replace($old, $new)
+            Set-Content $path $content -NoNewline
+          } elseif (-not $content.Contains('recoveryStage is CopyStartedStage or CopyCompletedStage')) {
+            throw 'Expected recovery marker guard was not found.'
+          }
+
+          dotnet format
+          if (-not (git diff --quiet)) {
+            git config user.name github-actions[bot]
+            git config user.email 41898282+github-actions[bot]@users.noreply.github.com
+            git add -u
+            git commit -m 'fix(moves): require manifest for direct-copy recovery markers'
+            git push origin HEAD:${{ github.head_ref }}
+          }
+      - name: Run tests and report compact failures
+        shell: pwsh
+        env:
+          GH_TOKEN: ${{ github.token }}
+          PR_NUMBER: ${{ github.event.pull_request.number }}
+        run: |
+          $ErrorActionPreference = 'Continue'
+          dotnet test tests/Listenarr.Tests.csproj --no-restore --logger "trx;LogFileName=test-results.trx" *> test.log
+          $status = $LASTEXITCODE
+
+          $diagnostics = [System.Collections.Generic.List[string]]::new()
+          $trxPath = Get-ChildItem -Path tests/TestResults -Filter test-results.trx -Recurse | Select-Object -First 1
+          if ($trxPath) {
+            [xml]$trx = Get-Content $trxPath.FullName
+            $namespace = [System.Xml.XmlNamespaceManager]::new($trx.NameTable)
+            $namespace.AddNamespace('t', 'http://microsoft.com/schemas/VisualStudio/TeamTest/2010')
+            $failed = $trx.SelectNodes("//t:UnitTestResult[@outcome='Failed']", $namespace)
+            foreach ($result in $failed) {
+              $diagnostics.Add("FAILED: $($result.testName)")
+              $message = $result.SelectSingleNode('t:Output/t:ErrorInfo/t:Message', $namespace)
+              $stack = $result.SelectSingleNode('t:Output/t:ErrorInfo/t:StackTrace', $namespace)
+              if ($message) { $diagnostics.Add($message.InnerText.Trim()) }
+              if ($stack) { $diagnostics.Add($stack.InnerText.Trim()) }
+              $diagnostics.Add('')
+            }
+          }
+
+          if ($diagnostics.Count -eq 0) {
+            $diagnostics.AddRange([string[]](Get-Content test.log | Select-Object -Last 80))
+          }
+
+          @(
+            '<!-- temporary-windows-test-diagnostics-compact -->'
+            '### Temporary Windows test diagnostics'
+            ''
+            "Exit code: ``$status``"
+            ''
+            '```text'
+            $diagnostics
+            '```'
+          ) | Set-Content diagnostics.md
+          gh pr comment $env:PR_NUMBER --body-file diagnostics.md
+          if ($status -ne 0) { exit 1 }

CONTRIBUTING.md

@@ -414,5 +414,6 @@ If you have any questions about contributing, please:
   4. In `listenarr.api/Program.cs` call the infrastructure registration extension instead of registering types inline.
   5. Delete the old API placeholder files and run `dotnet test` to verify no regressions.
 - Add a small DI/registration unit test (DependencyInjectionTests) that asserts required services are resolvable; run it early in CI to catch layering regressions.
+- Create EF Core migrations with `dotnet ef migrations add` only. Do not hand-author migration `.cs`, `.Designer.cs`, or model snapshot files; generated migrations may be reviewed, but the scaffold is the source of truth so EF discovery metadata and accumulated snapshots stay complete.
 
 Thank you for contributing to Listenarr! 🎵📚