Skip to content

fix(hash): throw on unsupported hash type #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LimiNode merged 1 commit into from
Sep 3, 2025
Merged

fix(hash): throw on unsupported hash type #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions hmac.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ namespace hmac {
ctx.finish(digest);
return std::string((const char*)digest, hmac_hash::SHA512::DIGEST_SIZE);
}
default: break;
default:
throw std::invalid_argument("Unsupported hash type");
};
return std::string();
}

std::vector<uint8_t> get_hash(const void* data, size_t length, TypeHash type) {
Expand Down Expand Up @@ -78,7 +78,8 @@ namespace hmac {
ctx.finish(digest.data());
return digest;
}
default: return {};
default:
throw std::invalid_argument("Unsupported hash type");
}
}

Expand Down Expand Up @@ -150,7 +151,7 @@ namespace hmac {
block_size = hmac_hash::SHA512::SHA384_512_BLOCK_SIZE;
break;
default:
return std::string();
throw std::invalid_argument("Unsupported hash type");
};

std::string key = key_input;
Expand Down
18 changes: 18 additions & 0 deletions test_all.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,17 @@ TEST(HashTest, SHA512LargeInput) {
"596d71e02b4eca81f668215d3e9b9e5a143a9c3d8d1981608e0811b20e290961ec2a7e7ecd0e275366cf10aa5f7ab1e052b868c5fa57b6d2bd6e75477b2ecea7");
}

TEST(HashTest, InvalidTypeThrowsString) {
auto invalid = static_cast<hmac::TypeHash>(999);
EXPECT_THROW(hmac::get_hash("grape", invalid), std::invalid_argument);
}

TEST(HashTest, InvalidTypeThrowsBuffer) {
auto invalid = static_cast<hmac::TypeHash>(999);
const char data[] = "grape";
EXPECT_THROW(hmac::get_hash(data, sizeof(data) - 1, invalid), std::invalid_argument);
}

TEST(UtilsTest, ToHex) {
EXPECT_EQ(hmac::to_hex("012345"), "303132333435");
}
Expand Down Expand Up @@ -93,6 +104,13 @@ TEST(HMACTest, InvalidTypeThrows) {
EXPECT_THROW(hmac::get_hmac(key, 3, msg, 3, invalid), std::invalid_argument);
}

TEST(HMACTest, InvalidTypeThrowsString) {
const std::string key = "key";
const std::string msg = "abc";
auto invalid = static_cast<hmac::TypeHash>(999);
EXPECT_THROW(hmac::get_hmac(key, msg, invalid), std::invalid_argument);
}

TEST(TOTPTest, AtTime) {
const std::string totp_key = "12345678901234567890";
uint64_t test_time = 1234567890;
Expand Down
Loading