Skip to content

Add post-review gate for NOTE/WARNING findings before merge#97

Merged
sebastientaggart merged 1 commit into
devfrom
feature/post-review-gate
Apr 11, 2026
Merged

Add post-review gate for NOTE/WARNING findings before merge#97
sebastientaggart merged 1 commit into
devfrom
feature/post-review-gate

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

When the AI review approves with non-blocking findings (NOTE/WARNING items), the flow now pauses and asks the user whether to address findings first or merge now — instead of merging immediately. Clean reviews with no findings still auto-merge.

Issue #94

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

No issues found. Code looks correct and follows project conventions.

The new gate logic correctly distinguishes clean approvals (auto-merge) from approvals with non-blocking findings (pause and ask). The "merge now" path properly chains into Step 9's follow-up issue offer, and the "address" path correctly halts without merging. All five files (source template + four adapter copies) carry identical changes with appropriate hash updates.

@sebastientaggart
sebastientaggart merged commit fe7f4e0 into dev Apr 11, 2026
2 checks passed
@sebastientaggart
sebastientaggart deleted the feature/post-review-gate branch April 11, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant