Skip to content

Fix deploy-prod tag clobber and add validate to make dev#90

Merged
sebastientaggart merged 1 commit into
devfrom
feature/deploy-prod-tag-force
Apr 10, 2026
Merged

Fix deploy-prod tag clobber and add validate to make dev#90
sebastientaggart merged 1 commit into
devfrom
feature/deploy-prod-tag-force

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

make deploy-prod was failing with "would clobber existing tag" rejections when local release tags diverged from the remote. Split the combined pull into a branch rebase plus a forced tag fetch so the remote remains authoritative for release tags.

Also wire ./sync.sh --validate into make dev so placeholder validation runs alongside the dry-run preview as a preflight check.

Closes #89

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

  • [NOTE] The git fetch origin --tags --force in deploy-prod will overwrite any local release tags to match the remote, which is the intended authoritative behavior described in the PR and matches the fix for Fix 'make deploy-prod' failing when local tags diverge from remote tags #89.
  • [NOTE] Adding ./sync.sh --validate before ./sync.sh --dry-run in the dev target correctly fails fast on placeholder errors since make halts on the first non-zero exit.

@sebastientaggart
sebastientaggart merged commit 3722b45 into dev Apr 10, 2026
2 checks passed
@sebastientaggart
sebastientaggart deleted the feature/deploy-prod-tag-force branch April 10, 2026 00:00
@sebastientaggart sebastientaggart mentioned this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant