Skip to content

Fix sync.sh --validate to respect {{#if}} conditionals #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastientaggart merged 1 commit into from
Apr 9, 2026
Merged

Fix sync.sh --validate to respect {{#if}} conditionals #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sync.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,11 @@ def validate_placeholders(skill_files, project_config):
for skill_path in skill_files:
raw = skill_path.read_text()
fm, body = parse_frontmatter(raw)
# Check body and frontmatter description
text_to_check = body
# Evaluate conditionals first — placeholders inside stripped blocks
# are not part of the final output and should not be reported.
text_to_check = apply_conditionals(body, project_config)
if fm.get('description'):
text_to_check += '\n' + fm['description']
text_to_check += '\n' + apply_conditionals(fm['description'], project_config)
missing = [p for p in find_unresolved(text_to_check) if p not in project_config]
for p in missing:
errors.append(f" {skill_path.name}: {{{{{p}}}}} not defined in config")
Expand Down