Fix awkward TICKET_LABEL_CREATION_ALLOWED substitutions in start skill#81
Merged
Merged
Conversation
Member
Author
Review SummaryVerdict: APPROVE Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
startskill template substituted{{TICKET_LABEL_CREATION_ALLOWED}}verbatim into narrative prose, producing awkward rendered sentences like "If label creation is allowed (false=true, case-insensitive)" and "unless{{TICKET_LABEL_CREATION_ALLOWED}}=true". Purely cosmetic, but confusing for readers of the generated skill files.Changes:
sync.sh:apply_conditionalsnow treats'false','no', and'0'(case-insensitive) as falsy, in addition to empty strings, so config values likeTICKET_LABEL_CREATION_ALLOWED: falsework intuitively in{{#if}}blocks.skills/start.md: Replaced the two awkward label-creation passages (pool-resolution body and hard-rules bullet) with{{#if TICKET_LABEL_CREATION_ALLOWED}}/{{#if !TICKET_LABEL_CREATION_ALLOWED}}branches that read naturally in either configuration.skills/submit-for-review.md: Reworded the "regardless of{{TICKET_LABEL_CREATION_ALLOWED}}" sentence to avoid substituting the raw value into prose.Issue #77