Skip to content

Rephrase start skill to avoid tautology after TICKET_LABEL_CREATION_ALLOWED substitution#72

Merged
sebastientaggart merged 1 commit into
devfrom
feature/start-label-creation-wording
Apr 8, 2026
Merged

Rephrase start skill to avoid tautology after TICKET_LABEL_CREATION_ALLOWED substitution#72
sebastientaggart merged 1 commit into
devfrom
feature/start-label-creation-wording

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

Three sites in skills/start.md phrased the TICKET_LABEL_CREATION_ALLOWED check as `{{TICKET_LABEL_CREATION_ALLOWED}}` is `true` (or false). After sync.sh substitutes the placeholder with its literal boolean value, those sentences became tautologies (e.g. `false` is `true`, omit (or create if falseistrue)). Rewrote them so the substituted output reads naturally regardless of value:

  • Label resolution step 3a: If label creation is allowed (\{{TICKET_LABEL_CREATION_ALLOWED}}` = `true`, case-insensitive) ...`
  • Label resolution step 3b: Otherwise (\{{TICKET_LABEL_CREATION_ALLOWED}}` = `false` or unset) ...`
  • Hard-rules bullet: ... → omit (or, when \{{TICKET_LABEL_CREATION_ALLOWED}}` = `true`, create). Never apply a label outside `{{TICKET_LABELS}}` unless `{{TICKET_LABEL_CREATION_ALLOWED}}` = `true`.`

Adapters (.claude, .cursor, .agents, .gemini) regenerated via ./sync.sh. Pure wording fix — no behavior change.

Issue #71

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

No issues found. Code looks correct and follows project conventions.

The template change in skills/start.md replaces tautological phrasings (e.g. "If false is true") that arose after sync.sh substitutes {{TICKET_LABEL_CREATION_ALLOWED}} with its literal boolean, using clearer wording ("If label creation is allowed (false = true, case-insensitive)"). The four regenerated adapter outputs (.claude/commands/start.md, .cursor/rules/start.mdc, .agents/skills/start/SKILL.md, .gemini/skills/start/SKILL.md) match the template change exactly, and their generator hashes were updated. No behavioral change, no secrets, no convention violations.

@sebastientaggart
sebastientaggart merged commit 47d89f3 into dev Apr 8, 2026
2 checks passed
@sebastientaggart
sebastientaggart deleted the feature/start-label-creation-wording branch April 8, 2026 17:00
This was referenced Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant