Rephrase start skill to avoid tautology after TICKET_LABEL_CREATION_ALLOWED substitution#72
Merged
Conversation
…LLOWED substitution
Member
Author
Review SummaryVerdict: APPROVE FindingsNo issues found. Code looks correct and follows project conventions. The template change in skills/start.md replaces tautological phrasings (e.g. "If |
This was referenced Apr 8, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three sites in
skills/start.mdphrased theTICKET_LABEL_CREATION_ALLOWEDcheck as`{{TICKET_LABEL_CREATION_ALLOWED}}` is `true`(orfalse). After sync.sh substitutes the placeholder with its literal boolean value, those sentences became tautologies (e.g.`false` is `true`,omit (or create iffalseistrue)). Rewrote them so the substituted output reads naturally regardless of value:If label creation is allowed (\{{TICKET_LABEL_CREATION_ALLOWED}}` = `true`, case-insensitive) ...`Otherwise (\{{TICKET_LABEL_CREATION_ALLOWED}}` = `false` or unset) ...`... → omit (or, when \{{TICKET_LABEL_CREATION_ALLOWED}}` = `true`, create). Never apply a label outside `{{TICKET_LABELS}}` unless `{{TICKET_LABEL_CREATION_ALLOWED}}` = `true`.`Adapters (
.claude,.cursor,.agents,.gemini) regenerated via./sync.sh. Pure wording fix — no behavior change.Issue #71