Skip to content

Rename /ship to /submit-for-review#38

Merged
sebastientaggart merged 2 commits into
devfrom
feature/rename-ship-to-submit-for-review-v2
Mar 26, 2026
Merged

Rename /ship to /submit-for-review#38
sebastientaggart merged 2 commits into
devfrom
feature/rename-ship-to-submit-for-review-v2

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

Rename the /ship skill to /submit-for-review across all source files, adapter configs, documentation, and templates. Regenerate all adapter files via sync.sh.

Also adds a "Working on parallel branches" section to docs/branching.md with guidance on sequencing cross-cutting changes to avoid merge conflicts.

Issue #35

…ance

Rename the ship skill to submit-for-review across all source files, adapter
configs, documentation, and templates. Run sync.sh to regenerate all adapter
files. Add a "Working on parallel branches" section to docs/branching.md
with guidance on sequencing cross-cutting changes to avoid merge conflicts.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

  • [WARNING] templates/AGENTS.md.template still contains @ship on the Cursor reference line: - **Cursor:** \@start`, `@ship`, etc. in Agent mode. This should be updated to @submit-for-review` for consistency with the rest of the rename. This is a non-blocking cosmetic inconsistency — the template generates AGENTS.md in consumer projects, so the stale reference will propagate until fixed.
  • [NOTE] The "Working on parallel branches" section added to docs/branching.md is well-written and relevant advice. No issues.

All other replacements across skills, adapters, docs, templates, config schema, and sync.sh are consistent and correct. File renames (skill source, generated adapter files) are properly paired with content updates. Hash values in generated file footers have been regenerated.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@sebastientaggart
sebastientaggart merged commit 7328a17 into dev Mar 26, 2026
1 check passed
@sebastientaggart sebastientaggart mentioned this pull request Mar 27, 2026
@sebastientaggart
sebastientaggart deleted the feature/rename-ship-to-submit-for-review-v2 branch April 8, 2026 14:44
sebastientaggart added a commit that referenced this pull request Apr 8, 2026
…mit-for-review-v2

Rename /ship to /submit-for-review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant