Skip to content

Fix sync-check CI: sync adapter files and bump checkout to v5#25

Merged
sebastientaggart merged 1 commit into
devfrom
feature/fix-sync-check-ci
Mar 26, 2026
Merged

Fix sync-check CI: sync adapter files and bump checkout to v5#25
sebastientaggart merged 1 commit into
devfrom
feature/fix-sync-check-ci

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

Sync the generated adapter files for ship and start skills across all 4 adapters (claude, cursor, codex, gemini) and bump actions/checkout from v4 to v5 to resolve the Node.js 20 deprecation warning.

Issue #24

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

No issues found. Code looks correct and follows project conventions.

  • New "Sync with base branch" step is consistently added to all 4 ship adapters (claude, cursor, codex, gemini) with correct step renumbering and updated cross-references (e.g., Step 7 → Step 8).
  • "Trunk mode" parenthetical correctly removed from all 4 start adapters.
  • actions/checkout bump v4 → v5 is appropriate.
  • Footer hashes regenerated; typo fix CodeCanonCodeCannon in ship footers is a nice cleanup.

@sebastientaggart
sebastientaggart merged commit 7f693e8 into dev Mar 26, 2026
2 checks passed
@sebastientaggart sebastientaggart mentioned this pull request Mar 26, 2026
@sebastientaggart
sebastientaggart deleted the feature/fix-sync-check-ci branch April 8, 2026 14:44
sebastientaggart added a commit that referenced this pull request Apr 8, 2026
Fix sync-check CI: sync adapter files and bump checkout to v5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant