Skip to content

Strip leading @ from reviewer handles in ship skill #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastientaggart merged 2 commits into from
Mar 26, 2026
Merged

Strip leading @ from reviewer handles in ship skill #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32286fb
Strip leading @ from reviewer handles before passing to gh pr create
Mar 26, 2026
a7e63b5
Merge origin/dev into feature/strip-reviewer-at-prefix
Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/skills/ship/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ EOF
)"
```

Add `--reviewer @sebastientaggart` to the `gh pr create` command above.
Add `--reviewer` to the `gh pr create` command above using the handles from `@sebastientaggart`. Before passing them, strip any leading `@` from each comma-separated handle (e.g. `@alice,@org/team` becomes `alice,org/team`) — the `gh` CLI requires bare usernames.

If a CODEOWNERS file exists, both apply: CODEOWNERS triggers automatic review requests from GitHub; the `--reviewer` flag adds the explicitly configured handles on top.

Expand Down Expand Up @@ -185,4 +185,4 @@ Report success based on mode:
- When `ai` is `"off"`, skip the review agent entirely — merge immediately after checks pass.
- `/ship` merges only to `dev` — never directly to `main`.
- If `make merge` fails for any reason, report it and stop — do not attempt workarounds.
<!-- generated by CodeCannon/sync.sh | skill: ship | adapter: codex | hash: a0f3cbc1 | DO NOT EDIT — run CodeCannon/sync.sh to regenerate -->
<!-- generated by CodeCanon/sync.sh | skill: ship | adapter: codex | hash: a3a69a6b | DO NOT EDIT — run CodeCanon/sync.sh to regenerate -->
4 changes: 2 additions & 2 deletions .claude/commands/ship.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ EOF
)"
```

Add `--reviewer @sebastientaggart` to the `gh pr create` command above.
Add `--reviewer` to the `gh pr create` command above using the handles from `@sebastientaggart`. Before passing them, strip any leading `@` from each comma-separated handle (e.g. `@alice,@org/team` becomes `alice,org/team`) — the `gh` CLI requires bare usernames.

If a CODEOWNERS file exists, both apply: CODEOWNERS triggers automatic review requests from GitHub; the `--reviewer` flag adds the explicitly configured handles on top.

Expand Down Expand Up @@ -180,4 +180,4 @@ Report success based on mode:
- When `ai` is `"off"`, skip the review agent entirely — merge immediately after checks pass.
- `/ship` merges only to `dev` — never directly to `main`.
- If `make merge` fails for any reason, report it and stop — do not attempt workarounds.
<!-- generated by CodeCannon/sync.sh | skill: ship | adapter: claude | hash: 147893a6 | DO NOT EDIT — run CodeCannon/sync.sh to regenerate -->
<!-- generated by CodeCanon/sync.sh | skill: ship | adapter: claude | hash: 07e388c6 | DO NOT EDIT — run CodeCanon/sync.sh to regenerate -->
4 changes: 2 additions & 2 deletions .cursor/rules/ship.mdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ EOF
)"
```

Add `--reviewer @sebastientaggart` to the `gh pr create` command above.
Add `--reviewer` to the `gh pr create` command above using the handles from `@sebastientaggart`. Before passing them, strip any leading `@` from each comma-separated handle (e.g. `@alice,@org/team` becomes `alice,org/team`) — the `gh` CLI requires bare usernames.

If a CODEOWNERS file exists, both apply: CODEOWNERS triggers automatic review requests from GitHub; the `--reviewer` flag adds the explicitly configured handles on top.

Expand Down Expand Up @@ -186,4 +186,4 @@ Report success based on mode:
- When `ai` is `"off"`, skip the review agent entirely — merge immediately after checks pass.
- `/ship` merges only to `dev` — never directly to `main`.
- If `make merge` fails for any reason, report it and stop — do not attempt workarounds.
<!-- generated by CodeCannon/sync.sh | skill: ship | adapter: cursor | hash: adfbb790 | DO NOT EDIT — run CodeCannon/sync.sh to regenerate -->
<!-- generated by CodeCanon/sync.sh | skill: ship | adapter: cursor | hash: 8def7114 | DO NOT EDIT — run CodeCanon/sync.sh to regenerate -->
4 changes: 2 additions & 2 deletions .gemini/skills/ship/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ EOF
)"
```

Add `--reviewer @sebastientaggart` to the `gh pr create` command above.
Add `--reviewer` to the `gh pr create` command above using the handles from `@sebastientaggart`. Before passing them, strip any leading `@` from each comma-separated handle (e.g. `@alice,@org/team` becomes `alice,org/team`) — the `gh` CLI requires bare usernames.

If a CODEOWNERS file exists, both apply: CODEOWNERS triggers automatic review requests from GitHub; the `--reviewer` flag adds the explicitly configured handles on top.

Expand Down Expand Up @@ -185,4 +185,4 @@ Report success based on mode:
- When `ai` is `"off"`, skip the review agent entirely — merge immediately after checks pass.
- `/ship` merges only to `dev` — never directly to `main`.
- If `make merge` fails for any reason, report it and stop — do not attempt workarounds.
<!-- generated by CodeCannon/sync.sh | skill: ship | adapter: gemini | hash: e5d350e7 | DO NOT EDIT — run CodeCannon/sync.sh to regenerate -->
<!-- generated by CodeCanon/sync.sh | skill: ship | adapter: gemini | hash: 964084a6 | DO NOT EDIT — run CodeCanon/sync.sh to regenerate -->
2 changes: 1 addition & 1 deletion skills/ship.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ EOF
```

{{#if DEFAULT_REVIEWERS}}
Add `--reviewer {{DEFAULT_REVIEWERS}}` to the `gh pr create` command above.
Add `--reviewer` to the `gh pr create` command above using the handles from `{{DEFAULT_REVIEWERS}}`. Before passing them, strip any leading `@` from each comma-separated handle (e.g. `@alice,@org/team` becomes `alice,org/team`) — the `gh` CLI requires bare usernames.

If a CODEOWNERS file exists, both apply: CODEOWNERS triggers automatic review requests from GitHub; the `--reviewer` flag adds the explicitly configured handles on top.
{{/if}}
Expand Down
Loading