Skip to content

Fix unresolved placeholders for trunk-based workflows#19

Merged
sebastientaggart merged 3 commits into
devfrom
feature/fix-unresolved-placeholders
Mar 26, 2026
Merged

Fix unresolved placeholders for trunk-based workflows#19
sebastientaggart merged 3 commits into
devfrom
feature/fix-unresolved-placeholders

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

Wraps {{BRANCH_DEV}}, {{PLATFORM_COMPLIANCE_NOTES}}, and {{CONVENTIONS_NOTES}} in {{#if}} conditional blocks so they are only included when defined in the project config.

Previously, projects using trunk-based workflow (no BRANCH_DEV) or leaving compliance/conventions notes undefined would see warnings about unresolved placeholders during sync.

Issue #18

sebastientaggart and others added 3 commits March 25, 2026 21:17
Update all shipped skills that ship with this project
…conditional blocks to prevent unresolved placeholder warnings for trunk-based workflows
@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

No issues found. Code looks correct and follows project conventions.

The PR does two things, both correct:

  1. Typo fix (CodeCanon -> CodeCannon): Consistent rename across all generated files, source skills, templates, docs, and sync.sh itself. The MARKER constant in sync.sh is updated, and the marker-line f-string matches. All adapters (claude, cursor, gemini, codex) are covered.

  2. Conditional placeholder wrapping: {{BRANCH_DEV}}, {{PLATFORM_COMPLIANCE_NOTES}}, and {{CONVENTIONS_NOTES}} are wrapped in {{#if}} / {{#if !}} blocks in the source skills (start.md, review-agent.md). The syntax matches the apply_conditionals() parser in sync.sh (which expects {{#if KEY}} / {{#if !KEY}} / {{/if}} on their own lines with uppercase keys). The trunk-mode fallback in start.md correctly uses {{BRANCH_PROD}} instead. Generated output files (.claude/commands/review.md, .claude/review-agent-prompt.md, etc.) show the conditionals were resolved correctly by sync, with placeholder-free output and updated hashes where content changed.

@sebastientaggart
sebastientaggart merged commit 940eed0 into dev Mar 26, 2026
0 of 2 checks passed
@sebastientaggart sebastientaggart mentioned this pull request Mar 26, 2026
@sebastientaggart
sebastientaggart deleted the feature/fix-unresolved-placeholders branch April 8, 2026 14:44
sebastientaggart added a commit that referenced this pull request Apr 8, 2026
…ceholders

Fix unresolved placeholders for trunk-based workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant