Skip to content

Trim /setup skill and remove ROADMAP.md#112

Merged
sebastientaggart merged 2 commits into
devfrom
feature/trim-setup-skill
Apr 11, 2026
Merged

Trim /setup skill and remove ROADMAP.md#112
sebastientaggart merged 2 commits into
devfrom
feature/trim-setup-skill

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

Trim /setup skill from 475 to 371 lines (22% reduction) by removing redundant content:

  • Removed skills reference table from State 1 (already in README)
  • Merged greenfield label guidance into Phase 2's existing label population flow
  • Compressed Phase 3 config walkthrough into a pattern definition + table instead of repeating longhand for each value
  • Factored out shared profile selection questions

Also deletes ROADMAP.md — all items have been addressed or captured as backlog tickets.

No behavioral changes to the setup wizard.

Issue #111

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

  • [NOTE] The greenfield guidance moved from Phase 3 to Phase 2 drops the explicit baseline label set recommendation (work intake + QA lifecycle + priority labels) and the interactive "Want me to help apply this baseline now?" prompt — Phase 2's existing zero-label handler already covers label creation, so the practical impact is minimal, but the priority label suggestion (priority:high/medium/low) is lost entirely.
  • [NOTE] The TICKET_LABEL_CREATION_ALLOWED table entry no longer mentions "Defaults to false", which was present in the original longhand description — an LLM following the skill may not infer the default.

No correctness or security issues. The refactoring preserves all behavioral flows (profile selection, confirmation gates, write-only-on-yes). ROADMAP deletion is justified — swarm mode is captured in issue #109, /status enhancements shipped in PR #107, /checkpoint skill exists, and three-branch Makefile is tracked as issue #6.

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary (re-review)

Verdict: APPROVE

Both notes from the prior review have been addressed:

  • The "defaults to false" clarification for TICKET_LABEL_CREATION_ALLOWED is now present in the Phase 3 table (line 339).
  • The priority label suggestion (priority:high, priority:medium, priority:low) and milestone guidance are now included in the Phase 2 greenfield note (line 291), merged naturally into the label population flow.

No new issues found. The refactoring correctly preserves all behavioral flows (profile selection, confirmation gates, write-only-on-yes, per-profile value scoping) while reducing duplication through shared patterns and table-driven definitions. ROADMAP deletion remains justified.

@sebastientaggart
sebastientaggart merged commit 7820952 into dev Apr 11, 2026
0 of 2 checks passed
@sebastientaggart
sebastientaggart deleted the feature/trim-setup-skill branch April 11, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant