Standardise setting of viewport and timestamp, other general cleanup - #698
Open
qroll wants to merge 5 commits into
Open
Standardise setting of viewport and timestamp, other general cleanup#698qroll wants to merge 5 commits into
qroll wants to merge 5 commits into
Conversation
qroll
marked this pull request as ready for review
July 29, 2026 05:50
iant-gds
reviewed
Jul 29, 2026
| // shares the same bounding box as the main canvas element. | ||
| const box = await story.locators.imageEditor.boundingBox(); | ||
|
|
||
| if (!box) { |
Contributor
There was a problem hiding this comment.
just wondering why did you choose to throw the error manually instead of something like expect(box).not.toBeNull() and let playwright do the error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Description of changes
Checklist
Looks good on mobile and tabletUpdated documentationAdded/updated unit tests