Skip to content

[CCUBE-2200][RYN] Migrate file-upload component - #674

Merged
qroll merged 6 commits into
pre-release/v3from
CCUBE-2200
Jul 28, 2026
Merged

[CCUBE-2200][RYN] Migrate file-upload component#674
qroll merged 6 commits into
pre-release/v3from
CCUBE-2200

Conversation

@ryan-nguyen-t

@ryan-nguyen-t ryan-nguyen-t commented Jul 22, 2026

Copy link
Copy Markdown

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests

@ryan-nguyen-t ryan-nguyen-t self-assigned this Jul 22, 2026
@qroll qroll added the type: chore For technical improvements or refactoring. label Jul 22, 2026
qroll
qroll requested changes Jul 22, 2026
View reviewed changes
Comment thread e2e/tests/utils/image-fixtures.ts Outdated
Comment thread e2e/tests/components/fields/file-upload/file-upload.e2e.spec.ts
Comment thread e2e/nextjs-app/app/components/fields/file-upload/form-states.e2e.tsx Outdated
Comment thread ...tests/components/fields/file-upload/__screenshots__/chromium/FileUpload-Thumbnail--mount.png
Comment thread ...onents/fields/file-upload/__screenshots__/chromium/FileUpload-Upload-interactions--mount.png Outdated
Comment thread e2e/tests/components/fields/file-upload/file-upload.e2e.spec.ts Outdated
Comment thread e2e/tests/components/fields/file-upload/file-upload.e2e.spec.ts Outdated
@qroll qroll added this to the v3.0.0-alpha.1 milestone Jul 22, 2026
@ryan-nguyen-t
ryan-nguyen-t requested a review from qroll July 23, 2026 06:07
qroll
qroll requested changes Jul 24, 2026
View reviewed changes
Comment thread e2e/tests/components/fields/file-upload/file-upload.e2e.spec.ts Outdated
Comment thread e2e/tests/components/fields/file-upload/file-upload.e2e.spec.ts Outdated
Comment thread e2e/tests/components/fields/file-upload/file-upload.e2e.spec.ts Outdated
await fileChooser.setFiles(SAMPLE_PNG_PAYLOAD);

await expect(story.locators.getFileName(SAMPLE_PNG_PAYLOAD.name)).toBeVisible();
await story.snapshot("uploaded-through-button", { locator: story.locators.dropzone });

@qroll qroll Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can exclude the locator arg by default for all the snapshots

Comment thread e2e/tests/components/fields/file-upload/file-upload.e2e.spec.ts Outdated
@qroll

qroll commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

tests are failing on the pipeline

@qroll

qroll commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

reinstall node modules (DS was bumped) and regenerate the snapshots

also removed the unused ones

@qroll
qroll merged commit a31c65c into pre-release/v3 Jul 28, 2026
1 of 2 checks passed
@qroll
qroll deleted the CCUBE-2200 branch July 28, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qroll qroll qroll approved these changes
@ghazwan-gt ghazwan-gt ghazwan-gt approved these changes

Assignees

@ryan-nguyen-t ryan-nguyen-t

Labels

type: chore For technical improvements or refactoring.

Projects

None yet

Milestone

v3.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ryan-nguyen-t @qroll @ghazwan-gt