Skip to content

[MOL-21511][TIEN] track image-upload by id - #653

Open
tientranngoc-alt wants to merge 1 commit into
mainfrom
MOL-21511
Open

[MOL-21511][TIEN] track image-upload by id#653
tientranngoc-alt wants to merge 1 commit into
mainfrom
MOL-21511

Conversation

@tientranngoc-alt

Copy link
Copy Markdown

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

  • Link to ticket
  • Image-upload updated images by array index, so async compress/upload could apply progress/status to the wrong image after the list changed. Fixed by updating via stable id.
  • Fix image-upload race when images are added/removed during compress/upload by updating image state by stable id instead of array index
  • Apply compress/convert/upload/error updates via patchImageById, and use fileItem.id as the React list key

Checklist

  • [] Changes follow the project guidelines in CONTRIBUTING.md
  • [] Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests

Screenshots

N/A – logic fix only, no visual changes

@tientranngoc-alt
tientranngoc-alt marked this pull request as ready for review July 13, 2026 09:46
@tientranngoc-alt tientranngoc-alt self-assigned this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant