Add package.json for scripts/ + extract taste-skill appendices to reference/ - #75
Open
internetinext-jpg wants to merge 1 commit into
Open
Conversation
…eference/ Two independent, low-risk fixes: 1. scripts/*.mjs import sharp but the repo has no package.json, lockfile, or install docs, so every script fails immediately with "Cannot find module 'sharp'". Adds a minimal package.json (private, type: module, npm run aliases) plus package-lock.json and a .gitignore for node_modules. Verified sharp installs and a script runs past the import stage (fails only on a missing source PNG that isn't part of this fix). 2. Extracts Appendix A/B/C from skills/taste-skill/SKILL.md (install commands, canonical doc links, Apple Liquid Glass approximation) into skills/taste-skill/reference/*.md, trimming the always-loaded file from 1206 to 990 lines. Content is copied verbatim (diffed against the original, byte-identical); only pointers replace the inline appendices. This is the safe, scoped version of what Leonxlnx#38 and Leonxlnx#67 ask for: it does not touch the decision-making sections (0-14), so skill behavior is unchanged, just lighter to load. Addresses Leonxlnx#38. Partial progress on Leonxlnx#67 (a deeper restructure of sections 0-14 is a larger, more opinionated call left to the maintainer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Two independent, low-risk fixes found while auditing the repo:
1.
scripts/*.mjscan't run — nopackage.jsonAll four scripts under
scripts/importsharp, but there is nopackage.json, lockfile, or install instructions anywhere in the repo. Running any of them fails immediately withCannot find module 'sharp'.Adds a minimal
package.json(private: true,type: module,npm runaliases for each script) +package-lock.json+ a.gitignorefornode_modules/.Verified:
npm installsucceeds,sharpresolves and reports its version, andnode scripts/convert-readme-assets-webp.mjsruns past the import stage (it then fails looking for a source PNG that isn't part of this fix — expected, unrelated).2. Extract
taste-skillappendices toreference/(addresses #38, partial progress on #67)skills/taste-skill/SKILL.mdwas 1206 lines. Appendix A (install commands), Appendix B (canonical doc links), and Appendix C (Apple Liquid Glass web approximation) are reference material the agent only needs when a brief calls for that specific design system or aesthetic — not on every load.Moved them to:
skills/taste-skill/reference/install-commands.mdskills/taste-skill/reference/canonical-sources.mdskills/taste-skill/reference/apple-liquid-glass.mdContent is copied verbatim — diffed byte-for-byte against the original appendix text, identical.
SKILL.mdnow ends with three short pointer lines instead of the inline appendices: 1206 → 990 lines (~18% smaller), with zero change to sections 0–14 (the actual decision-making rules), so skill behavior is unchanged.This is intentionally the safe, scoped version of what #67 asks for. A deeper restructure of sections 0-14 into core + on-demand reference is a bigger, more opinionated call I left for you to decide, since it would touch the actual design-rule content rather than just relocating clearly-separable reference material.
Testing
npm install— succeeds, 0 vulnerabilitiesnode -e "require('sharp')"— resolves, prints versionnode scripts/convert-readme-assets-webp.mjs— runs past the previously-broken importSKILL.mdfrontmatter, all section headers (0 through 14), and the final pre-flight checklist are untouchedNot included
Did not touch the
name:/directory mismatch from #62 (10 skills) since that PR is already open and further ahead on that specific fix — didn't want to create merge conflicts by duplicating it here.