Print the stack trace when a plugin fails to load due to an exception thrown from its constructor#18
Open
zhro wants to merge 1 commit into
Open
Conversation
Print the stack trace when a plugin fails to load due to an exception thrown from its constructor.
Owner
|
Would and nice if you could move the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been having issues using this plugin manager for development where the plugin fails to load due to an exception being thrown from the plugin's constructor. SpigotPluginManager would swallow the exception and simply report
PM | Could not load the plugin <name>. (Invalid plugin file), which did not provide any useful information as to where the error occurred.I added a simple call to
printStackTrace()in theloadPlugin()method to fix this. There are some other exceptions nearby that don't print a stack trace either, but I don't have any tests for them, and further modifications are outside the scope of my current use case.