fix: disable set -e during main loop to allow retry on transient API …#209
Open
sainthardrock wants to merge 1 commit into
Open
fix: disable set -e during main loop to allow retry on transient API …#209sainthardrock wants to merge 1 commit into
sainthardrock wants to merge 1 commit into
Conversation
…errors The main loop retry logic handles non-zero exit codes by sleeping 30s and continuing, but set -e at line 6 kills the script before retry can work. Adding set +e before the while loop lets transient network errors trigger the retry path instead of a fatal unexpected_exit. The circuit breaker (record_loop_result) still protects against real stagnation — it only tracks progress during successful executions. Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ralph/ralph_loop.shline 6 hasset -ewhich kills the script ontransient errors (e.g. "Connection closed mid-response") before the
retry logic in
main()can work.Fix
One-line: add
set +ebefore the main while loop. The circuit breakerstill protects against real stagnation.
Checklist
fix:)bash -n ralph/ralph_loop.sh)npm run ci— TypeScript tests only, not relevant to this bash change