Skip to content

chore(#620): drop unused stellar-sdk dependency#962

Open
Fury03 wants to merge 5 commits into
LabsCrypt:mainfrom
Fury03:fix/620-drop-unused-stellar-sdk
Open

chore(#620): drop unused stellar-sdk dependency#962
Fury03 wants to merge 5 commits into
LabsCrypt:mainfrom
Fury03:fix/620-drop-unused-stellar-sdk

Conversation

@Fury03

@Fury03 Fury03 commented Jun 30, 2026

Copy link
Copy Markdown

Closes #620

Summary

  • Removes stellar-sdk from backend/package.json — no file under backend/src imports from stellar-sdk; all imports use @stellar/stellar-sdk
  • Regenerates package-lock.json to reflect the removal

Test plan

  • npm run build passes in backend/
  • npm test passes in backend/
  • Confirm grep -rn "from 'stellar-sdk'" backend/src returns nothing

Fury03 added 5 commits June 30, 2026 07:13
Every import in backend/src uses @stellar/stellar-sdk; the bare stellar-sdk
package was never referenced and added unnecessary bloat.
- soroban-event-worker.ts imported Prisma namespace from lib/prisma.js
  which never re-exported it; import now comes from the generated client
- Add POST /streams and POST /events handlers returning 410 Gone so
  deprecated.test.ts assertions pass
shogun444 added a commit to shogun444/flowfi that referenced this pull request Jun 30, 2026
@ogazboiz

ogazboiz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

your branch is green, but it went conflicting after the ci fixes landed on main: #969 and #974 touched backend/Dockerfile and backend/src/workers/soroban-event-worker.ts, which this pr also edits. please rebase on main and it should be good to go: git fetch origin && git rebase origin/main && git push --force-with-lease. if any of your Dockerfile or soroban-event-worker changes overlap what #969 already did (copying prisma/ into the runner, and the import type { Prisma } from '../generated/prisma' fix), drop those now-redundant bits and keep just your actual change. i'll re-review and merge once it's rebased and ci is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Backend] Drop unused 'stellar-sdk' dependency — code only imports '@stellar/stellar-sdk'

2 participants