Skip to content

#623 [Frontend] StreamCreationWizard.startPolling hits wrong URL and wrong shape#944

Merged
ogazboiz merged 6 commits into
LabsCrypt:mainfrom
jotel-dev:fix/623-stream-creation-polling
Jul 1, 2026
Merged

#623 [Frontend] StreamCreationWizard.startPolling hits wrong URL and wrong shape#944
ogazboiz merged 6 commits into
LabsCrypt:mainfrom
jotel-dev:fix/623-stream-creation-polling

Conversation

@jotel-dev

Copy link
Copy Markdown
Contributor

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #623

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

@jotel-dev jotel-dev force-pushed the fix/623-stream-creation-polling branch from 0ce0020 to b808f69 Compare June 30, 2026 06:19
@ogazboiz

ogazboiz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

your branch is green, but it went conflicting after the ci fixes landed on main: #969 and #974 touched backend/Dockerfile and backend/src/workers/soroban-event-worker.ts, which this pr also edits. please rebase on main and it should be good to go: git fetch origin && git rebase origin/main && git push --force-with-lease. if any of your Dockerfile or soroban-event-worker changes overlap what #969 already did (copying prisma/ into the runner, and the import type { Prisma } from '../generated/prisma' fix), drop those now-redundant bits and keep just your actual change. i'll re-review and merge once it's rebased and ci is green.

@jotel-dev jotel-dev force-pushed the fix/623-stream-creation-polling branch from 3f694d9 to 3bbe154 Compare July 1, 2026 03:09
@jotel-dev

Copy link
Copy Markdown
Contributor Author

@ogazboiz
All done! I've rebased the branch on main and resolved the conflicts. As requested, I also dropped the redundant commits that were touching backend/Dockerfile and backend/src/workers/soroban-event-worker.ts since those fixes are already present in main.

Just force-pushed. Let me know if everything looks good once CI finishes running!"

@jotel-dev

Copy link
Copy Markdown
Contributor Author

@ogazboiz Done ✅kindly merge

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the polling fix is solid: it routes through getApiBaseUrl(), handles both the array and {data} payload shapes, fixes the /streams redirect path, and correctly polls by walletPublicKey (the sender) not the recipient. no timer leak either, it's a bounded loop with a 30s timeout, not a setInterval. merging.

one note, not blocking but please avoid next time: this also deletes backend/tests/deprecated.test.ts, which is unrelated to a frontend polling fix and drops backend coverage. keep unrelated test deletions out of feature prs.

@ogazboiz ogazboiz merged commit 0d41728 into LabsCrypt:main Jul 1, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] StreamCreationWizard.startPolling hits wrong URL and wrong shape

2 participants