#623 [Frontend] StreamCreationWizard.startPolling hits wrong URL and wrong shape#944
Conversation
0ce0020 to
b808f69
Compare
|
your branch is green, but it went conflicting after the ci fixes landed on main: #969 and #974 touched backend/Dockerfile and backend/src/workers/soroban-event-worker.ts, which this pr also edits. please rebase on main and it should be good to go: |
… URL and wrong shape
3f694d9 to
3bbe154
Compare
|
@ogazboiz Just force-pushed. Let me know if everything looks good once CI finishes running!" |
|
@ogazboiz Done ✅kindly merge |
ogazboiz
left a comment
There was a problem hiding this comment.
the polling fix is solid: it routes through getApiBaseUrl(), handles both the array and {data} payload shapes, fixes the /streams redirect path, and correctly polls by walletPublicKey (the sender) not the recipient. no timer leak either, it's a bounded loop with a 30s timeout, not a setInterval. merging.
one note, not blocking but please avoid next time: this also deletes backend/tests/deprecated.test.ts, which is unrelated to a frontend polling fix and drops backend coverage. keep unrelated test deletions out of feature prs.
Description
Type of Change
Related Issues
Closes #623
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes