Skip to content

Issue 53197: Field name with double byte character can cause client side exception in Firefox when trying to customize grid view - #2540

Merged
cnathe merged 14 commits into
developfrom
fb_customizeView53197
Jul 10, 2025
Merged

Issue 53197: Field name with double byte character can cause client side exception in Firefox when trying to customize grid view#2540
cnathe merged 14 commits into
developfrom
fb_customizeView53197

Conversation

@cnathe

@cnathe cnathe commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

Rationale

Issue 53197: Field name with double byte character can cause client side exception in Firefox when trying to customize grid view

Related Pull Requests

Changes

  • randomFieldName() to include WIDE_PLACEHOLDER

@labkey-tchad labkey-tchad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FieldInfo has had some improvements

Comment thread src/org/labkey/test/tests/component/GridPanelTest.java Outdated
Comment thread src/org/labkey/test/tests/component/GridPanelTest.java Outdated
Comment thread src/org/labkey/test/tests/component/GridPanelTest.java Outdated
Comment thread src/org/labkey/test/tests/component/GridPanelTest.java Outdated
@cnathe
cnathe requested a review from labkey-tchad July 9, 2025 12:15

@labkey-tchad labkey-tchad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts to resolve here. I made some changes to CustomizeView that just got merged to develop.

@cnathe
cnathe requested a review from labkey-tchad July 9, 2025 21:34

@labkey-tchad labkey-tchad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataRegionTable and CustomizeView support FieldInfo/FieldKey now.

Comment thread src/org/labkey/test/tests/component/GridPanelTest.java Outdated
Comment thread src/org/labkey/test/tests/component/GridPanelTest.java Outdated
Comment thread src/org/labkey/test/tests/component/GridPanelTest.java Outdated
Comment thread src/org/labkey/test/tests/component/GridPanelTest.java Outdated
Comment thread src/org/labkey/test/util/TestDataGenerator.java Outdated
@cnathe
cnathe merged commit 8f8fea0 into develop Jul 10, 2025
7 checks passed
@cnathe
cnathe deleted the fb_customizeView53197 branch July 10, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants