Spring AI version - #1259
Conversation
|
Looks like we need to resolve some conflicting dependency versions. org.antlr:ST4 has 2 versions as follows: |
# Conflicts: # gradle.properties
| springBootVersion=3.5.8 | ||
| # This usually matches the Spring Framework version dictated by springBootVersion | ||
| springVersion=6.2.15 | ||
| springAiVersion=1.1.2 |
There was a problem hiding this comment.
Do we need this at the root? Looks like it's only used in the API module. Do you expect other modules will need it before long?
Regardless, we need to resolve the handful of dependency version conflicts before this can be merged.
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Need to resolve dependency conflicts
I put springAIVersion here just to put it with its spring friends. I'm open to doing something else. I forced force antlrST4Version=4.3.4 (in platform). Seems to work, but I'm not sure how we maintain and review these exceptions. |
I believe we primarily rely on the comments in the line that forces the version. Thanks for adding one. @labkey-susanh any preference on where to set the Spring AI version? I thought it would live in the one module that uses it, but I don't see a |
|
@labkey-matthewb that cleared one of the four conflicts. We probably need forces for one or more of the others too. |
Often if there's just one usage, we won't capture it in a |
@labkey-matthewb here's the link to that "Upgrade Dependencies" doc: https://docs.google.com/document/d/1JPZ8al_M6eQh813Q8y3ALhRNgTieveaKDXv5iFUbq7A/edit?tab=t.0 |
| // exclude log4j 1.x, which may come in transitively, from all configurations to avoid its potential vulnerabilities | ||
| exclude group: "log4j", module:"log4j" | ||
| // exclude to ensure we don't have Log4J to SLFJ adapters or other unwanted logging libraries added to modules | ||
| exclude group: "org.springframework.boot", module:"spring-boot-starter-logging" |
There was a problem hiding this comment.
@labkey-susanh this is how I suppressed this transitive dependency from being pulled into modules. Happy to shift to a better place if you have a recommendation.
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
Looks like there's a need for a merge from develop? DRTs are failing.
| // exclude log4j 1.x, which may come in transitively, from all configurations to avoid its potential vulnerabilities | ||
| exclude group: "log4j", module:"log4j" | ||
| // exclude to ensure we don't have Log4J to SLFJ adapters or other unwanted logging libraries added to modules | ||
| exclude group: "org.springframework.boot", module:"spring-boot-starter-logging" |
Merged. |
3 participants
Rationale
set global dependency version
Related Pull Requests
Changes