Fix misleading permissions message for Guest users in MCP - #7894
Open
labkey-gokhano wants to merge 1 commit into
Open
Fix misleading permissions message for Guest users in MCP#7894labkey-gokhano wants to merge 1 commit into
labkey-gokhano wants to merge 1 commit into
Conversation
…hoAmITalkingTo Guest previously received the generic "unrestricted permissions" warning meant for unrestricted API keys, which is backwards since Guest is typically the least-privileged account on a server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
User.getPermissionsRestrictions()unconditionally returned "Current user has unrestricted permissions..." for any user not wrapped as aPermissionsRestrictedUser, which is backwards for Guest — Guest is normally the least-privileged account on a server, not an unrestricted one. This surfaced via the MCPwhereAmIWhoAmITalkingTotool: a connector configured with no API key authenticates as Guest and was told it had "unrestricted permissions" instead of being pointed at a scoped API key.Related Pull Requests
None
Changes
User.getPermissionsRestrictions()now checksisGuest()first and returns a Guest-specific message: "You have been connected as a Guest user with limited permissions. Please use an API Key with at least Read access permissions for a richer experience."