Container scoping for survey save template action. - #7887
Open
labkey-klum wants to merge 1 commit into
Open
Conversation
labkey-danield
approved these changes
Jul 28, 2026
labkey-danield
left a comment
labkey-danield
left a comment
Contributor
There was a problem hiding this comment.
Test looks ok to me.
labkey-adam
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR enforces container scoping when you are updating a survey design. Previously a user could reparent a survey design by only having read access to the design's container because we resolve the design by survey ID.
I ended up refactoring the
SurveyManager.getSurveyDesignmethod to have a version for read and write since in the read case we allow access from another container as long as the user has read access to the parent container. There is also a new unit test to cover this scenario.