PropertyColumn: do not cast float/decimal columns as varchar - #7617
Merged
Conversation
labkey-matthewb
approved these changes
Apr 22, 2026
labkey-matthewb
left a comment
labkey-matthewb
left a comment
Contributor
There was a problem hiding this comment.
Consider using a switch to get better guidance from the compiler?
labkey-nicka
force-pushed
the
fb_compound_components
branch
from
April 22, 2026 16:30
e6afc74 to
a55aac6
Compare
Contributor
Author
Good suggestion. Done. |
labkey-nicka
force-pushed
the
fb_compound_components
branch
2 times, most recently
from
April 23, 2026 19:36
88f71f6 to
68f9392
Compare
labkey-nicka
force-pushed
the
fb_compound_components
branch
from
April 25, 2026 20:20
68f9392 to
c0a51e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We know the underlying type of our
PropertyColumn. When the type is a float/decimal we currently cast to varchar when we seemingly should not / do not need to. This breaks interactions like filtering from a grid.Related Pull Requests
Changes