You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Text extracted from a couple of our test files shows small whitespace differences as of a recent Tika version (not sure which one); adjust test expectations accordingly. Also, run the test with strict=true going forward, so it fails when these expectations aren't met, which was the intent. The false setting is helpful when adjusting a large number of discrepancies, but not what we want on an on-going basis.
I haven't tried running this with the Tika update, but take your word that it will pass.
FYI: I noticed these discrepancies while testing 3.2.2, but turns out they aren't new. They show up on develop (3.2.1), but don't fail there because strict=false. So, this can be merged to develop prior to the merge forward.
I haven't tried running this with the Tika update, but take your word that it will pass.
FYI: I noticed these discrepancies while testing 3.2.2, but turns out they aren't new. They show up on develop (3.2.1), but don't fail there because strict=false. So, this can be merged to develop prior to the merge forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Text extracted from a couple of our test files shows small whitespace differences as of a recent Tika version (not sure which one); adjust test expectations accordingly. Also, run the test with
strict=truegoing forward, so it fails when these expectations aren't met, which was the intent. Thefalsesetting is helpful when adjusting a large number of discrepancies, but not what we want on an on-going basis.