Add auditing of what method was used for data imports, updates, deletes - #944
Merged
Conversation
This was referenced Oct 24, 2025
Merged
There was a problem hiding this comment.
Pull Request Overview
This PR updates the saveExperimentRun method signature in the Luminex module to add support for transaction audit details. The change accommodates a new parameter for transaction auditing that was likely introduced in the parent DefaultAssayRunCreator API.
Key changes:
- Added
TransactionAuditProvider.TransactionDetailparameter tosaveExperimentRunmethod signature - Updated all method calls to
saveExperimentRunto passnullfor the new parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| LuminexRunCreator.java | Updated method signature to accept transactionDetails parameter and pass it to parent class |
| WellExclusionTable.java | Updated call to saveExperimentRun to pass null for new transactionDetails parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }); | ||
| addColumn(wellsCol); | ||
|
|
||
| List<FieldKey> defaultCols = new ArrayList<>(getDefaultVisibleColumns()); |
There was a problem hiding this comment.
Variable 'List defaultCols' is never read.
| { | ||
| String description = rowMap.get("Description") == null ? null : rowMap.get("Description").toString(); | ||
| String type = rowMap.get("Type") == null ? null : rowMap.get("Type").toString(); | ||
| String bTRUE = getSchema().getSqlDialect().getBooleanTRUE(); |
There was a problem hiding this comment.
Variable 'String bTRUE' is never read.
Suggested change
| String bTRUE = getSchema().getSqlDialect().getBooleanTRUE(); | |
| // Removed unused variable bTRUE |
cnathe
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR updates the
saveExperimentRunmethod signature in the Luminex module to add support for transaction audit details. The change accommodates a new parameter for transaction auditing that was likely introduced in the parentDefaultAssayRunCreatorAPI.Related Pull Requests
Changes
TransactionAuditProvider.TransactionDetailparameter tosaveExperimentRunmethod signaturesaveExperimentRunto passnullfor the new parameter