Improve floating text boxes (TextFloat and TextFloatSimple) - #8448
Improve floating text boxes (TextFloat and TextFloatSimple)#8448jlintgod1 wants to merge 6 commits into
Conversation
Also did some style cleanup and adjusted widget layout (especially noticable when resizing clips)
…lips Might change so it always uses the last mouse position?
|
Thanks for making this! Code review wise, everything looks alright. 2026-06-29.21-55-09.mp4 |
Oops must've missed that Co-authored-by: Yohanan <[email protected]>
I noticed that too while working on the PR (and isn't caused by it), but I wasn't sure about how to fix it until I actually looked into it. It's caused by lmms/src/gui/tracks/TrackContentWidget.cpp Lines 276 to 291 in cd9a0de The simplest solution might be to have clip views not moved from where they're calculated to be (based on the clip's position), but I still need to figure out if there are performance impacts. |
|
nooo, why was this closed? |
|
In hindsight, it might've been better to not close it, but I just kinda went through a rough moment (still technically going through it) and feel very unmotivated. Hence why I closed it for no reason. I probably won't figure out how to test performance impacts for a little bit though. |
|
Oh, I see, no pressure. In case you don't want to work on it, you can also signal it and others can chime in to continue the work. Either way, hope you get through your situation, good luck! |
This PR adds some quality-of-life improvements to floating text boxes (
TextFloatandTextFloatSimple), including:TextFloata bit smaller and make it more stable with changing text (particularly noticeable when adjusting the length of a clip)Comparison Videos
Before (current Nightly):
2026-06-29.15-49-46_small.mp4
After:
2026-06-29.16-23-45_small.mp4