Adjustable Light#581
Open
Rasmuslnd wants to merge 2 commits into
Open
Conversation
Reworks the Creatures tab into a unified Models/Creatures browser: - A browse-mode switch toggles the file list between models and creatures without leaving the tab; the last-used mode is remembered (lastBrowseMode). - Creature preview gains equipment display (armor/weapons from NPC equipment data) with per-slot toggles, alongside geoset and skin controls. - The texture ribbon for this tab floats bottom-center over the preview. - Adds a viewer title, model/settings sidebar sub-tabs, and an auto-play-animation option (creatureAutoPlayAnim). Scope note: viewer lighting / zone-lighting controls and the character armory-info panel are deliberately excluded and will be submitted as their own PRs, so this change is limited to the tab itself.
Adds user-controllable lighting to the model/creature preview: - "Adjustable light" mode with a draggable direction gizmo plus intensity and ambient sliders and a reset button, alongside Render Shadow and Use 3D Camera toggles, in the viewer settings panel. - Renderer support (model-viewer-gl, M2RendererGL) applies the configured azimuth/elevation/intensity/ambient to the model. - Persisted via new config keys (modelViewerCustomLight, modelViewerLight*, modelViewerShowShadow, modelViewerUse3DCamera). Also includes the rendering infrastructure for in-game zone lighting (zone-lighting.js, built on the upstream FogDataProvider/LightData); the renderer queries it for light uniforms. Its UI is currently gated off (v-if="false") pending completion, so adjustable light is the only user-facing mode in this change. Stacked on the Models/Creatures tab branch (the light controls live in that tab) - merge that PR first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add adjustable viewer lighting
Adds user-controllable lighting to the model/creature preview:
and ambient sliders and a reset button, alongside Render Shadow and
Use 3D Camera toggles, in the viewer settings panel.
azimuth/elevation/intensity/ambient to the model.
modelViewerShowShadow, modelViewerUse3DCamera)