Feature/Data scraper - #164
Merged
Merged
Conversation
Close to all the images work, and the admin can now edit all the images Apologies for the huge lines changed the system is running as usual
4 tasks
KitheK
changed the title
Collaborator
|
Great work, image handling flow looks solid and the admin permission on the router for updating the amazon links is a good idea for replacement. Tests pass, endpoints look good |
Collaborator
|
Nice job scraping the images, this works great and will be perfect for our project. Looks ready to merge to me, all tests passing good work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close to all the images work, and the admin can now has a router to change the the image link from amazon since the links expire
Apologies for the huge lines changed the system is running as usual
Features implemented:
Create ImageScraperService #160
Implement POST /products/{id}/fetch-image #161
Implement POST /products/fetch-images-all #162
Protect all image-fetch endpoints with admin_required #163