Feature/basic anomaly alerts - #158
Merged
Merged
Conversation
Implement GET /admin/metrics/anomalies Identify only basic anomalies: Sudden spike in penalties Products with unusually high number of reviews in short time Provide simple, rule-based checks Store nothing permanently: generated on request
Closed
4 tasks
Collaborator
|
Looks great. I like the new admin metrics router and anomaly endpoints. These will be really useful for monitoring. The different pie charts will be great. Nice that you added unit and integration tests, tests pass. Good job! |
Collaborator
|
Looks great, I like the pi charts theyll do great for the analytics dashboard we have coming, I resolved the conflicts it was just an issue in main.py relating to instantiating routers. They are now all included. All tests passed. Go ahead and merge when you're ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement GET /admin/metrics/anomalies
Identify only basic anomalies
Sudden spike in penalties being handed out to a specific user
Products with unusually high number of reviews in short time
Provide simple, rule-based checks
Store nothing permanently: generated on request