Skip to content

Reduce the suppression for warnings. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kim-J-Smith merged 3 commits into from
Jul 19, 2026
Merged

Reduce the suppression for warnings. #92

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5aea163
chore: remove diagnostic suppression for "-Wuninitialized".
Kim-J-Smith Jul 17, 2026
47a50fb
style: adjust some code style.
Kim-J-Smith Jul 17, 2026
bd12930
docs: revert comments about when it is trivial.
Kim-J-Smith Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 10 additions & 32 deletions include/embed/embed_function.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,13 +1034,8 @@ inline namespace fn_traits {

// In view mode, the requires is special.
// See <https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2026/p3961r1.html>.
static constexpr bool noexcept_qualifier_ok =
(unwrap_to::isNoexcept == unwrap_from::isNoexcept)
|| (
CfgTo::isView == true
&& CfgFrom::isView == true
&& unwrap_to::isNoexcept < unwrap_from::isNoexcept
);
static constexpr bool noexcept_qualifier_ok = unwrap_to::isNoexcept == unwrap_from::isNoexcept
|| (CfgTo::isView && CfgFrom::isView && unwrap_to::isNoexcept < unwrap_from::isNoexcept);

static constexpr bool qualifier_ok =
(unwrap_to::hasConst <= unwrap_from::hasConst)
Expand Down Expand Up @@ -1075,7 +1070,7 @@ inline namespace fn_traits {
struct is_nothrow_construct_from_functor<
Functor, Class, void_t<decltype( Class(std::declval<Functor>()) )>>
: public bool_constant<
noexcept(::new (static_cast<void*>(0)) Class(std::declval<Functor>()))
noexcept(::new (static_cast<void*>(nullptr)) Class(std::declval<Functor>()))
> {};

// Get invoke result with arguments package.
Expand Down Expand Up @@ -2776,31 +2771,14 @@ namespace crtp_mixins {
EMBED_NODISCARD EMBED_INLINE static constexpr bool
is_copyable() noexcept { return internal_is_copyable; }

#if defined(__GNUC__)
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wuninitialized"
#endif
/// @brief All following methods that end with `= default` are implemented in
/// the base class @e `crtp_mixins::lifetime_operations_impl`.

// The destructor of the function wrapper, is trivial if `Config::isView == true`.
~function() = default;
// The copy constructor of the function wrapper, `=delete` if `(Config::isView ||
// Config::isCopyable) == true`, and is trivial if `Config::isView == true`.
function(const function& other) = default;
// The move constructor of the function wrapper, is trivial if
// `(Config::isView || Config::isCopyable) == true`.
function(function&& other) = default;
// The copy assignment of the function wrapper, `=delete` if `(Config::isView ||
// Config::isCopyable) == true`, and is trivial if `Config::isView == true`.
function& operator=(const function& other) = default;
// The move assignment of the function wrapper, is trivial if
// `(Config::isView || Config::isCopyable) == true`.
function& operator=(function&& other) = default;

#if defined(__GNUC__)
# pragma GCC diagnostic pop
#endif
/// the base class @e `crtp_mixins::lifetime_operations_impl`. They are trivial
/// if `Config::isView` equals `true`.
~function() = default;
Comment thread
Kim-J-Smith marked this conversation as resolved.
function(const function& other) = default;
function(function&& other) = default;
function& operator=(const function& other) = default;
function& operator=(function&& other) = default;

/// Implemented in the base class @e `crtp_mixins::core_components_impl`.
using Base_CoreComponents::operator=;
Expand Down