tests: unify encoder/decoder captured-output rendering - #214
Open
dabrain34 wants to merge 1 commit into
Open
Conversation
dabrain34
changed the title
dabrain34
force-pushed
the
dab_fix_verbose_encoder
branch
from
June 11, 2026 13:16
fe9ef82 to
5908cb2
Compare
dabrain34
changed the title
dabrain34
force-pushed
the
dab_fix_verbose_encoder
branch
from
June 11, 2026 13:44
5908cb2 to
33cc30d
Compare
Move build_decoder_command into the decoder framework and reuse it from the encoder, dropping it and the validation flow from base. Render output via a generic meta["output_sections"] list each framework populates, so base needs no encoder/decoder knowledge. The encoder appends its decoder-validation output after its own, matching runtime order. Extract the encoder validation flow into _run_decoder_validation_stage.
dabrain34
force-pushed
the
dab_fix_verbose_encoder
branch
from
June 11, 2026 14:24
33cc30d to
c365e39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move build_decoder_command into the decoder framework and reuse it
from the encoder, dropping it and the validation flow from base.
Render output via a generic meta["output_sections"] list each
framework populates, so base needs no encoder/decoder knowledge.
The encoder appends its decoder-validation output after its own,
matching runtime order. Extract the encoder validation flow into
_run_decoder_validation_stage.
Type of change
bug fix
Issue (optional)
Tests
NVIDIA GeForce RTX 3050 Ti Laptop GPU / NVIDIA 595.44.00 / Ubuntu 24.04.4 LTS
Total Tests: 79
Passed: 62
Crashed: 0
Failed: 0
Not Supported: 16
Skipped: 1 (in skip list)
Success Rate: 100.0%
Additional Details (optional)