Skip to content

layers: Update spirv-val to detect untyped explicit layout - #12788

Open
spencer-lunarg wants to merge 1 commit into
KhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-alan-awesome-new-check-inside-spirv-val
Open

layers: Update spirv-val to detect untyped explicit layout#12788
spencer-lunarg wants to merge 1 commit into
KhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-alan-awesome-new-check-inside-spirv-val

Conversation

@spencer-lunarg

@spencer-lunarg spencer-lunarg commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Alan made it possible so we can pass in VkPhysicalDeviceDescriptorHeapPropertiesEXT and do the sanity check people are not messing up their SPV_EXT_descriptor_heap logic with bogus size/alignment without having to redo all the work in VVL

KhronosGroup/SPIRV-Tools#6792

@spencer-lunarg
spencer-lunarg requested a review from a team as a code owner July 29, 2026 15:54
@ci-tester-lunarg

ci-tester-lunarg commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 58324.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24024 running.

@spencer-lunarg spencer-lunarg mentioned this pull request Jul 29, 2026
Merged
@ci-tester-lunarg

ci-tester-lunarg commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24024 failed.

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-alan-awesome-new-check-inside-spirv-val branch from 0ab426e to 3507459 Compare July 30, 2026 02:27
@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 58865.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24027 running.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24027 failed.

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-alan-awesome-new-check-inside-spirv-val branch from 3507459 to dfe68c1 Compare July 30, 2026 12:04
@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 59180.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24028 running.

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-alan-awesome-new-check-inside-spirv-val branch from dfe68c1 to 5b90594 Compare July 30, 2026 12:25
@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 59197.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24029 running.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24029 failed.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 59303.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24031 running.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24031 failed.

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-alan-awesome-new-check-inside-spirv-val branch from 5b90594 to e48f6bc Compare July 30, 2026 16:45
@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 59670.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24033 running.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24033 failed.

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-alan-awesome-new-check-inside-spirv-val branch from e48f6bc to ee4c8f9 Compare July 30, 2026 18:13
@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 59862.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24037 running.

@ci-tester-lunarg

ci-tester-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24037 failed.

@spencer-lunarg

spencer-lunarg commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

this is failing on Android (one of the devices) and it makes ZERO sense... going to try splitting this up

@spencer-lunarg spencer-lunarg mentioned this pull request Jul 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ziga-lunarg ziga-lunarg ziga-lunarg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spencer-lunarg @ci-tester-lunarg @ziga-lunarg