layers: Track debug names at object creation time - #12395
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 765832. |
44f40a1 to
4bc5e58
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 765844. |
|
CI Vulkan-ValidationLayers build # 23524 running. |
| if (name_info->pObjectName) { | ||
| debug_utils_object_name_map[object_handle] = name_info->pObjectName; | ||
| } | ||
| // Given this function is called at object creation time, |
There was a problem hiding this comment.
good call, should add a VU to just ban having a null pObjectName when passed in (forgot this was a feature of this extension)
|
|
||
| from base_generator import BaseGenerator, SetOutputDirectory, SetTargetApiName, SetMergedApiNames, EnableCaching | ||
| _orig_endFile = BaseGenerator.endFile | ||
| def _patched_endFile(self): |
There was a problem hiding this comment.
this is a bit too crazy of a hack for my taste (also I want to make generate_source.py simpler to begin)
just add something to generator_utils.py that takes the self.vk.structs and returns it with the fields updated
There was a problem hiding this comment.
Since it is a hack, goal is to make it simple to remove, having everything in one spot really helps, even though logic is insane
There was a problem hiding this comment.
having everything in one spot really helps
ya, that is what generator_utils.py right?
There was a problem hiding this comment.
But then 2 files are modified at 2 spots, IMO it's more cumbersome to remove
|
CI Vulkan-ValidationLayers build # 23524 passed. |
4bc5e58 to
ca275b5
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 765974. |
|
CI Vulkan-ValidationLayers build # 23527 running. |
ca275b5 to
bc4cae0
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 766073. |
|
CI Vulkan-ValidationLayers build # 23528 running. |
|
CI Vulkan-ValidationLayers build # 23528 failed. |
bc4cae0 to
926f06e
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 766812. |
|
CI Vulkan-ValidationLayers build # 23531 running. |
|
CI Vulkan-ValidationLayers build # 23531 aborted. |
| } | ||
| record_obj.result = result; | ||
|
|
||
| for (uint32_t i = 0; i < createInfoCount; ++i) { |
There was a problem hiding this comment.
something I realized, with this, if we hit an error while creating the object, we now actually have the opportunity to provide a debug name at object creation time, which we could do if we had some way make it simple to search on an error message (like in LogError or something)
There was a problem hiding this comment.
Yeah piping down this new info to LogError is not straightforward
926f06e to
68b1347
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 767695. |
|
CI Vulkan-ValidationLayers build # 23560 running. |
|
CI Vulkan-ValidationLayers build # 23560 passed. |
3 participants
Closes #12393
Still need to handle VkDebugUtilsObjectTagInfoEXTVVL does not use VkDebugUtilsObjectTagInfoEXT