vulkaninfo: Add VK_KHR_display support and related fixes

[hapakj]

Add VK_KHR_display support and related fixes to vulkaninfo

[ci-tester-lunarg]

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

[charles-lunarg]

Looks like a lot of good defensive checks around surfaces that should of been there before, plus all the display improvements.

[ci-tester-lunarg]

CI Vulkan-Tools build queued with queue ID 8195.

[ci-tester-lunarg]

CI Vulkan-Tools build # 1987 running.

[ci-tester-lunarg]

CI Vulkan-Tools build # 1987 failed.

[charles-lunarg]

windows failure

execute() call failed after 0.06 seconds (0.06 seconds): returncode=3221225477 (0xc0000005=STATUS_ACCESS_VIOLATION); execution log index: 14, working directory: C:\j\w4\64-bit\Release\vulkantest-results\vulkaninfo-mockicd

macOS failure

VkPhysicalDeviceSwapchainMaintenance1FeaturesEXT:
-------------------------------------------------
	swapchainMaintenance1 = t
ERROR: ----stack trace----------------------------------------------
Core file '/Users/lunarg/.jenkins/w4/64-bit/Release/vulkantest-results/vulkaninfo/core' (arm64) was loaded.
* thread #1, stop reason = ESR_EC_DABORT_EL0 (fault address: 0x10)
  * frame #0: 0x00000001951c5820 libobjc.A.dylib`objc_msgSend + 32
    frame #1: 0x000000010686ab4c libMoltenVK.dylib`-[MVKBlockObserver stopObserving] + 36
    frame #2: 0x000000010686aa78 libMoltenVK.dylib`-[MVKBlockObserver dealloc] + 24
    frame #3: 0x0000000106891498 libMoltenVK.dylib`MVKSurface::~MVKSurface() + 80
    frame #4: 0x00000001068914e4 libMoltenVK.dylib`MVKSurface::~MVKSurface() + 12
    frame #5: 0x000000010688cda4 libMoltenVK.dylib`vkDestroySurfaceKHR + 84
    frame #6: 0x0000000100e50ae0 libvulkan.1.4.350.dylib`terminator_DestroySurfaceKHR + 212
    frame #7: 0x0000000100e50a00 libvulkan.1.4.350.dylib`vkDestroySurfaceKHR + 108
    frame #8: 0x0000000100c65750 vulkaninfo`AppInstance::~AppInstance() + 80
    frame #9: 0x0000000100c55de8 vulkaninfo`main + 3740
    frame #10: 0x0000000195249d54 dyld`start + 7184
ERROR: -------------------------------------------------------------
ERROR: FAIL during test after 28.40 seconds (28.40 seconds) with execute(/Users/lunarg/.jenkins/w4/64-bit/Release/Vulkan-Tools/build/install/bin/vulkaninfo) failed after 10.92 seconds (10.92 seconds) with returncode=-11 (-0xb=SIGSEGV)

[aqnuep]

Thanks, @charles-lunarg we'll look into the failures.

Is the Windows failure that you see with a simple Mock ICD based setup? Because we did test this on Windows with multiple drivers.

[charles-lunarg]

Yes, this is the longer log (that I should of included from the get go)

INFO: exercising vulkaninfo with MockICD...
INFO: MockICD found at C:\j\w4\64-bit\Release\Vulkan-Tools\build\icd\Release\VkICD_mock_icd.json
INFO: set VK_ICD_FILENAMES=C:\j\w4\64-bit\Release\Vulkan-Tools\build\icd\Release\VkICD_mock_icd.json
INFO: cd C:\j\w4\64-bit\Release\vulkantest-results\vulkaninfo-mockicd
INFO: executing #14: C:\j\w4\64-bit\Release\Vulkan-Tools\build\install\bin\vulkaninfo.exe
ERROR: execute() call failed after 0.06 seconds (0.06 seconds): returncode=3221225477 (0xc0000005=STATUS_ACCESS_VIOLATION); execution log index: 14, working directory: C:\j\w4\64-bit\Release\vulkantest-results\vulkaninfo-mockicd
ERROR: FAIL during test after 4.86 seconds (4.86 seconds) with execute(C:\j\w4\64-bit\Release\Vulkan-Tools\build\install\bin\vulkaninfo.exe) failed after 0.06 seconds (0.06 seconds) with returncode=3221225477 (0xc0000005=STATUS_ACCESS_VIOLATION)

[ci-tester-lunarg]

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

CI Vulkan-Tools build queued with queue ID 8770.

[ci-tester-lunarg]

CI Vulkan-Tools build # 1989 running.

[ci-tester-lunarg]

CI Vulkan-Tools build # 1989 failed.

[charles-lunarg]

Now only the macOS CI failed:

Device Properties and Extensions:
=================================
GPU0:
VkPhysicalDeviceProperties:
---------------------------
	apiVersion        = 1.2.283 (4202779)
	driverVersion     = 0.2.2017 (10209)
	vendorID          = 0x106b
	deviceID          = 0x1a0103ef
	deviceType        = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU
	deviceName        = Apple M1
	pipelineCacheUUID = bf097edc-1a01-03ef-0000-000000000000

<output omitted>

VkPhysicalDeviceSubgroupSizeControlFeaturesEXT:
-----------------------------------------------
	subgroupSizeControl  = true
	computeFullSubgroups = true

VkPhysicalDeviceSwapchainMaintenance1FeaturesEXT:
-------------------------------------------------
	swapchainMaintenance1 = t
ERROR: ----stack trace----------------------------------------------
Core file '/Users/lunarg/.jenkins/w4/64-bit/Release/vulkantest-results/vulkaninfo/core' (arm64) was loaded.
* thread #1, stop reason = ESR_EC_DABORT_EL0 (fault address: 0x4258)
  * frame #0: 0x0000000193d65820 libobjc.A.dylib`objc_msgSend + 32
    frame #1: 0x000000010a062b4c libMoltenVK.dylib`-[MVKBlockObserver stopObserving] + 36
    frame #2: 0x000000010a062a78 libMoltenVK.dylib`-[MVKBlockObserver dealloc] + 24
    frame #3: 0x000000010a089498 libMoltenVK.dylib`MVKSurface::~MVKSurface() + 80
    frame #4: 0x000000010a0894e4 libMoltenVK.dylib`MVKSurface::~MVKSurface() + 12
    frame #5: 0x000000010a084da4 libMoltenVK.dylib`vkDestroySurfaceKHR + 84
    frame #6: 0x00000001048a4ae0 libvulkan.1.4.350.dylib`terminator_DestroySurfaceKHR + 212
    frame #7: 0x00000001048a4a00 libvulkan.1.4.350.dylib`vkDestroySurfaceKHR + 108
    frame #8: 0x00000001046b9760 vulkaninfo`AppInstance::~AppInstance() + 80
    frame #9: 0x00000001046a9df8 vulkaninfo`main + 3740
    frame #10: 0x0000000193de9d54 dyld`start + 7184
ERROR: -------------------------------------------------------------
ERROR: FAIL during test after 24.07 seconds (24.07 seconds) with execute(/Users/lunarg/.jenkins/w4/64-bit/Release/Vulkan-Tools/build/install/bin/vulkaninfo) failed after 6.48 seconds (6.48 seconds) with returncode=-11 (-0xb=SIGSEGV)