Skip to content

remove file mapping member in order to free file handles earlier - #401

Merged
hendrikmuhs merged 13 commits into
KeyviDev:masterfrom
hendrikmuhs:mmap-400
Feb 11, 2026
Merged

remove file mapping member in order to free file handles earlier#401
hendrikmuhs merged 13 commits into
KeyviDev:masterfrom
hendrikmuhs:mmap-400

Conversation

@hendrikmuhs

@hendrikmuhs hendrikmuhs commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

remove file_mapping member, see #400

Note: More changes due to clang-tidy

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread keyvi/include/keyvi/dictionary/fsa/automata.h
Comment thread keyvi/include/keyvi/dictionary/fsa/automata.h Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread keyvi/include/keyvi/dictionary/fsa/automata.h
Comment thread keyvi/include/keyvi/dictionary/fsa/automata.h Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h Outdated
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h Outdated
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h Outdated
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h
Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread keyvi/include/keyvi/dictionary/fsa/internal/memory_map_manager.h Outdated
@hendrikmuhs
hendrikmuhs merged commit 35297a4 into KeyviDev:master Feb 11, 2026
18 checks passed
@hendrikmuhs
hendrikmuhs deleted the mmap-400 branch February 11, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant