chore: address dotfiles audit findings#6
Merged
Conversation
- align runtime docs with current Windows strategy\n- correct bootstrap raw URL\n- add GitHub Actions test workflow for pytest and bats\n- remove tracked pytest cache artifacts\n\nCo-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR addresses dotfiles audit findings by updating documentation to reflect current runtime management practices, correcting bootstrap installation instructions, and adding CI coverage for existing test suites.
Changes:
- Update runtime documentation/examples (notably Node) and clarify Windows runtime management (fnm + winget/machine-local).
- Correct the bootstrap self-install URL to the actual tracked script path.
- Add a GitHub Actions workflow to run pytest and BATS tests on pushes/PRs.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates mise runtime example to use Node 24. |
| dot_local/bin/executable_bootstrap | Fixes the documented raw GitHub URL for self-install/bootstrap. |
| CLAUDE.md | Updates runtime documentation (Node example + Windows runtime manager table). |
| .github/workflows/dotfiles-tests.yml | Adds CI workflow to run pytest and BATS tests. |
| .chezmoiignore | Updates Windows runtime-related ignore commentary for clarity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+148
to
+152
| | Node.js | 24.x LTS | fnm | | ||
| | Python | 3.13 | winget / machine-local | | ||
| | Java | 21 (Temurin) | winget / machine-local | | ||
| | Rust | 1.95.x (stable) | rustup | | ||
| | Go | 1.26.x | mise | | ||
| | Bun | 1.3.x | mise | | ||
| | Deno | 2.7.x | mise | | ||
| | Zig | 0.16.x | mise | | ||
| | Go | 1.26.x | mise (optional, machine-local) | |
Contributor
There was a problem hiding this comment.
Fixed in a4e04fe — the mise upgrade comment now lists only bun, deno, go, zig (the runtimes actually managed by mise on Windows), and dedicated fnm install --lts / fnm default lts-latest commands were added for Node.js, making this consistent with the runtime table.
- broaden CI test discovery for pytest and bats\n- add cross-platform smoke matrix job\n- align Windows update commands with runtime managers\n- clarify README runtime scope for Windows\n\nCo-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- align runtime documentation with current Windows runtime management (fnm + machine-local runtimes)\n- correct bootstrap self-install URL to the actual repository path\n- add CI workflow to run pytest and bats on pushes/PRs\n- remove tracked tests/pycache artifacts\n\n## Validation\n- python -m pytest tests/test_obs.py -v