test: make API key status checks deterministic#2217
Open
JustinBacher wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
SIEM Toolfixture expires on 2026-07-08, but two tests expect it to be active. Once the real date passed that expiration, the tests began failing even though the production status calculation was correct.How this was discovered
This surfaced while installing the
keeper-commanderpackage from the Arch User Repository. The package build runs the upstream test suite duringcheck(), where these two tests failed after the fixture expiration date passed. Investigating the build failure showed that the package and production status logic were behaving correctly; the failure came from the tests depending on the real calendar date.Test plan