test(fuzz): add dedicated fuzz targets for rar2/rar3/rar5 - #120
Open
jdlien wants to merge 1 commit into
Open
Conversation
CONTRIBUTING promises every decoder a fuzz target, but the RAR decoders were only reachable through decoder_dispatch. Add one each, house pattern. Since RAR streams do not self-delimit, each derives out-of-band params from an input prefix (unpack size, rar3 E8 flag, rar5 window selector), capped at 1 MiB / 4 MiB so the fuzzer explores without gigabyte allocations. Registered in fuzz/Cargo.toml and the fuzz.yml matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING says every decoder gets a fuzz target, but the RAR decoders only had coverage via
decoder_dispatch. This adds dedicateddecoder_rar2/rar3/rar5targets following the existing pattern (loop-guard, out-of-band params derived from an input prefix — unpack size capped at 1 MiB, rar5 window capped at 4 MiB). Registered infuzz/Cargo.tomland thefuzz.ymlmatrix.Smoke-ran each ~10 min locally (nightly + cargo-fuzz): no crashes/OOMs/timeouts.