fix(adapters): make addDocuments atomic to prevent partial store corruption#2986
Conversation
…uption If ai.embed() failed on document N, documents 0..N-1 were already pushed into the store while N+1..end were missing, leaving the store in a corrupted partial state. Now all documents are embedded first via Promise.all, and only pushed to the store after all embeddings succeed. Fixes Karanjot786#2981
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Karanjot786 Please review this |
Summary
Made
addDocumentsatomic to prevent partial store corruption.Problem
If
ai.embed()failed on document N, documents 0..N-1 were already pushed into the store while N+1..end were missing, leaving the store in a corrupted partial state.Fix
All documents are now embedded first via
Promise.all, and only pushed to_documentsafter all embeddings succeed. If any embed fails, nothing is added to the store.Changed
packages/adapters/src/ai/vectorStore.ts: Changedforloop toPromise.allwith deferred pushFixes #2981