Skip to content

Feature/context menu clean#2976

Open
desireddymohithreddy0925 wants to merge 16 commits into
Karanjot786:mainfrom
desireddymohithreddy0925:feature/context-menu-clean
Open

Feature/context menu clean#2976
desireddymohithreddy0925 wants to merge 16 commits into
Karanjot786:mainfrom
desireddymohithreddy0925:feature/context-menu-clean

Conversation

@desireddymohithreddy0925

Copy link
Copy Markdown
Contributor

Description

This PR implements a global Context Menu system across @termuijs/core, @termuijs/widgets, and @termuijs/ui. It adds a ContextMenuManager in core that listens to right-clicks globally in App.ts. Widgets can now define a contextMenu array of items. When a right-click occurs on a widget with this property, it dispatches to a new ContextMenuOverlay in @termuijs/ui which mounts the existing ContextMenu widget safely at the highest z-index without manual layout state management from applications. All existing exports from ui/src/index.ts remain intact.

Related Issue

Closes #2858

Which package(s)?

@termuijs/core, @termuijs/widgets, @termuijs/ui

Type of Change

  • 🐛 Bug fix (type:bug)
  • ✨ Feature (type:feature)
  • 📝 Docs (type:docs)
  • 🧪 Tests (type:testing)
  • ♻️ Refactor (type:refactor)
  • 🎨 Design / UX (type:design)
  • ♿ Accessibility (type:accessibility)
  • ⚡ Performance (type:performance)
  • 🔧 DevOps / CI (type:devops)
  • 🔒 Security (type:security)

Checklist

  • ⭐ You starred the repo. The never rules are respected.
  • 🧪 Tests are included or updated.
  • 🏗️ bun run build passes locally.
  • 🧹 bun run lint and bun run typecheck pass locally.
  • 📦 The scope is strictly confined to the packages specified.

@github-actions github-actions Bot added area:widgets @termuijs/widgets area:core @termuijs/core area:ui @termuijs/ui type:testing +10 pts. Tests. labels Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@desireddymohithreddy0925, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 98fa4a97-cad2-4777-be4f-e764e16774b1

📥 Commits

Reviewing files that changed from the base of the PR and between 61eaa4e and 951afd2.

📒 Files selected for processing (7)
  • packages/core/src/app/App.ts
  • packages/core/src/app/ContextMenuManager.ts
  • packages/core/src/index.ts
  • packages/ui/src/ContextMenuOverlay.test.ts
  • packages/ui/src/ContextMenuOverlay.ts
  • packages/ui/src/index.ts
  • packages/widgets/src/base/Widget.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core @termuijs/core area:ui @termuijs/ui area:widgets @termuijs/widgets type:testing +10 pts. Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Context Menu System

1 participant