Skip to content

Pass reasons through motion cancellation#2965

Open
Tomeshwari-02 wants to merge 1 commit into
Karanjot786:mainfrom
Tomeshwari-02:issue/2954-motion-cancel-reason
Open

Pass reasons through motion cancellation#2965
Tomeshwari-02 wants to merge 1 commit into
Karanjot786:mainfrom
Tomeshwari-02:issue/2954-motion-cancel-reason

Conversation

@Tomeshwari-02

Copy link
Copy Markdown
Contributor

Summary

  • add an AnimationCancel type that accepts an optional reason
  • pass cancellation reasons through sequence, parallel, and repeat
  • export the cancellation type from the motion package

Tests

  • bun test packages/motion/src/sequence.test.ts packages/motion/src/repeat.test.ts

Closes #2954

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Tomeshwari-02, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f615706-8975-4720-b89e-58d3df80e8e4

📥 Commits

Reviewing files that changed from the base of the PR and between 61eaa4e and 9ce3252.

📒 Files selected for processing (4)
  • packages/motion/src/index.ts
  • packages/motion/src/repeat.test.ts
  • packages/motion/src/sequence.test.ts
  • packages/motion/src/sequence.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the type:testing +10 pts. Tests. label Jul 23, 2026
@Tomeshwari-02
Tomeshwari-02 marked this pull request as ready for review July 24, 2026 06:59
@Karanjot786

Copy link
Copy Markdown
Owner

Blocking — the reason is dead metadata. This threads an optional reason through sequence/parallel/repeat cancel functions, but nothing consumes it: leaf runners (transitions.ts fadeIn/out/slide/typewriter/pulse) and stagger.ts drop it, and no widget or onCancel(reason) hook reads it. Same pattern as the previously-blocked #2911 dirty-reason. Either wire a real consumer (e.g. an onCancel(reason) callback that something uses) or drop the plumbing. Checklist: [ ] reason actually consumed, or removed.

@Karanjot786 Karanjot786 added the quality:needs-work Needs changes before merge. label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality:needs-work Needs changes before merge. type:testing +10 pts. Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Add cancellation reason support to motion runners

2 participants