Skip to content

Clamp ScrollView offset on viewport changes#2961

Open
Tomeshwari-02 wants to merge 1 commit into
Karanjot786:mainfrom
Tomeshwari-02:issue/2950-scrollview-clamp
Open

Clamp ScrollView offset on viewport changes#2961
Tomeshwari-02 wants to merge 1 commit into
Karanjot786:mainfrom
Tomeshwari-02:issue/2950-scrollview-clamp

Conversation

@Tomeshwari-02

Copy link
Copy Markdown
Contributor

Summary

  • clamp ScrollView offsets after viewport rect changes
  • clamp any stale offset before rendering
  • update keybinding tests to use the environment mode read by the runtime

Tests

  • bun test packages/widgets/src/layout/ScrollView.test.ts

Closes #2950

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Tomeshwari-02, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dc165f5a-f210-4eaa-8dd7-004d9e6de16b

📥 Commits

Reviewing files that changed from the base of the PR and between 61eaa4e and f0695f4.

📒 Files selected for processing (2)
  • packages/widgets/src/layout/ScrollView.test.ts
  • packages/widgets/src/layout/ScrollView.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added area:widgets @termuijs/widgets type:testing +10 pts. Tests. labels Jul 23, 2026
@Tomeshwari-02
Tomeshwari-02 marked this pull request as ready for review July 24, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:widgets @termuijs/widgets type:testing +10 pts. Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] ScrollView keeps stale scroll offset after content shrinks

1 participant