fix(cli): normalize Windows backslashes in registry path matching#2933
fix(cli): normalize Windows backslashes in registry path matching#2933itssagarK wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRegistry path categorization and directory scanning now normalize Windows backslashes to forward slashes. Tests verify hook detection for a Windows-style path. ChangesPath normalization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks, but this reintroduces a double-push. Checklist: [ ] one push per file (old push removed) [ ] a test asserting no duplicate entries |
Pull Request Description
backslashes with
.replace(/\\/g, '/')prior to pattern matching.- Updated
scanDirectoryto normalizeROOTandfullpath strings for accurate relativepath construction.
- Added unit tests in
scripts/build-registry.test.tsverifying Windows backslash pathresolution for category detection.
Type of Change
type:bug)type:feature)type:docs)type:testing)type:refactor)type:design)type:accessibility)type:performance)type:devops)type:security)Checklist
needs-starcheck blocks your merge otherwise.bun vitest runbun run buildbun run typecheckCONTRIBUTING.md.type: short description.markDirty()(if your change affects rendering).anytypes without an inline comment explaining why.GSSoC 2026 Participation
https://gssoc.girlscript.org/profile/____Screenshots / Recordings (UI changes)
Notes for the Reviewer
Summary by CodeRabbit