answer by kindai_dai - #23
Open
kindaidai wants to merge 2 commits into
Open
Conversation
Owner
|
すでにチェック済みかもしれませんが、こちらの動画でコメントさせてもらいました！ 【前編】全部見ます！プロを目指すRailsエンジニアのための公開コードレビュー #railsdm - YouTube 【後編】全部見ます！プロを目指すRailsエンジニアのための公開コードレビュー #railsdm - YouTube |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
実装について
ここの条件分岐は、「2駅以下の場合は150円で移動できる」という考えで実装いたしました。
いつもevery day RSpec とqiitaの記事を参考にさせていただいております。
どのようなレビューになるのか楽しみです。